-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic online compatibility and a lot of other stuff #24
Conversation
Download the artifacts for this pull request: |
Were the hotkeys broken on the main branch? |
Is the migrationdatanode bs the same here as in gta? |
Yes. The P2Cs apparently ported that from YimMenu |
Figures |
Please split the PR next time, title is "Basic online compatibility" but i see you refactored the GUI and did other stuff that has nothing to do with online. It would be better if you do them one pr at a time so we can also review them easily and rapidly. That way we can avoid unnecessary code bugs and issues. |
if (!m_Handle || !m_Handle->m_PlayerInfo) | ||
return nullptr; | ||
|
||
return m_Handle->m_PlayerInfo->m_Ped; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really return an Entity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't, but we don't have a ped helper class yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't, but we don't have a ped helper class yet
PTR to handle? You already have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait does this even compile with no warnings/errors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually does
We were just confused about Entity
being a class instead of a typedef here. Odd name for that class.
|
||
if (ImGui::BeginChild("##options", ImVec2(0, 0), true)) | ||
{ | ||
if (m_OptionsFont) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to isolate core
and reuse it for other projects like YimMenuV2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to isolate
core
and reuse it for other projects like YimMenuV2
I mean the m_OptionsFont nullptr check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can choose not to have an options font
Also is hotkeys fixed? |
"TODO:
"? class next_column : public option {
public:
next_column() {};
void draw() override {
ImGui::NextColumn();
}
};
class set_column_offset : public option {
public:
set_column_offset(int column, int offset) : m_column(column), m_offset(offset) {};
void draw() override {
ImGui::SetColumnOffset(m_column, m_offset);
}
private:
int m_column;
int m_offset;
};
class column : public option {
public:
column(int columns) : m_columns(columns) {};
void add_option(std::shared_ptr<option> box) {
m_options.push_back(std::move(box));
}
void add_next_column() {
m_options.push_back(std::make_shared<next_column>());
}
void add_offset(int column, int offset) {
m_options.push_back(std::make_shared<set_column_offset>(column, offset));
}
void draw() override {
ImGui::Columns(m_columns);
for (const auto& box : m_options) {
if (box) {
box->draw();
}
}
}
private:
int m_columns;
std::vector<std::shared_ptr<option>> m_options;
};
``` This? |
Migrated to #36 |
TODO: